This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
WIP: cascading soft delete #2324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2324 +/- ##
==========================================
- Coverage 70.17% 69.99% -0.18%
==========================================
Files 171 171
Lines 16625 16610 -15
==========================================
- Hits 11666 11626 -40
- Misses 3829 3861 +32
+ Partials 1130 1123 -7
Continue to review full report at Codecov.
|
kwk
force-pushed
the
cascaded-soft-deletes
branch
from
cb7487f
to
69e24a6
Compare
kwk
force-pushed
the
cascaded-soft-deletes
branch
from
69e24a6
to
7854b21
Compare
kwk
force-pushed
the
cascaded-soft-deletes
branch
from
7854b21
to
1082cdb
Compare
kwk
requested review from
jarifibrahim,
baijum,
DhritiShikhar and
michaelkleinhenz
kwk
removed request for
baijum,
aslakknutsen,
xcoulon,
sbose78,
DhritiShikhar,
michaelkleinhenz,
jarifibrahim and
tinakurian
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE: DO NOT MERGE WHEN THERE'S ONLY ONE APPROVAL.
See https://github.com/fabric8-services/fabric8-wit/blob/12f42bbe747f33bf0e3fe485d35ff66ac021d613/docs/cascading-soft-delete.md#cascading-soft-deletes for a description of what this PR does and why.
In addition to adding the cascading soft-delete mechanism for our complete database, I had to make a few adjustments to some tables:
Delete no longer needed
work_item_link_categoriescategories that is no longer used since migration 106.Add missing foreign key constraint from
commentstowork_itemsitem and delete all comments that don't reference a work item.Change foreign key from
tracker_itemsandtracker_queriestotrackersfromON UPDATE RESTRICT ON DELETE RESTRICTtoON DELETE CASCADE.Change foreign key from
identitestouserstoON DELETE CASCADE.Implements [4] When a workitem is deleted, all links associated with it are deleted of Delete workitem #2304
Addresses Work items are not deleted when space is removed openshiftio/openshift.io#4382